Implement lastCompute #398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parker02311
reviewed
Dec 18, 2024
test/Spec/Memory/insert.spec.luau
Outdated
| print("AQUI!") | ||
| -- expect(#scope).to.equal(2) | ||
| -- doCleanup(scope) | ||
| -- expect(counter).to.equal(3) |
There was a problem hiding this comment.
Is there a reason this section was replaced with a print statement?
Or was it just left over from debugging?
There was a problem hiding this comment.
Oh yeah that's a mistake. Good catch
|
an alternate way to do this without modifying a lot of the files would be to do in evaluate.luau, and then set lastCompute in the "if needsComputation" block. |
|
Can you provide an example (with code) to highlight this issue happening with the current behavior? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an issue with the evaluate function.
In evaluate.luau look at the section of the code that decides whether a recompute is needed. Assume
dependency.lastChange > target.lastChangeis true for one of the dependencies.Then when the computation is complete assume the new value is the same, so "targetMeaningfullyChanged" is false and target.lastChange does not update.
Then dependency.lastChange > target.lastChange will remain true and the target will keep updating unnecessarily when it has already been computed with the new value of the dependency.
A fix to this would be to introduce another property, lastCompute, which tracks the last time a stateobject was updated.